Better error handling

javascript/fh_sdk.js

@@ -1,3 +1,13 @@
+class ValidationError extends Error {
+    constructor(message) {
+        if (!message) {
+            message = "ValidationError";
+        }
+        super(message);
+        this.name = "ValidationError";
+    }
+}
+
 class PlayerNotFoundError extends Error {
     constructor(message) {
         if (!message) {
@@ -65,6 +75,10 @@ class FairHopper {
             headers: this.defaultHeaders,
             body: JSON.stringify(payload),
         });
+        switch (r.status) {
+            case 422:
+                throw new ValidationError();
+        }
         return await r.json();
     }
 
@@ -84,6 +98,8 @@ class FairHopper {
                 throw new PlayerInactiveError();
             case 404:
                 throw new PlayerNotFoundError();
+            case 422:
+                throw new ValidationError();
         }
         return await r.json();
     }
@@ -117,6 +133,8 @@ class FairHopper {
                 throw new PlayerNotFoundError();
             case 409:
                 throw new PositionError();
+            case 422:
+                throw new ValidationError();
         }
         return await r.json();
     }
@@ -128,6 +146,17 @@ class FairHopper {
         return await r.json();
     }
 
+    async getProduct(productId) {
+        const r = await fetch(this.formatUrl(`/products/${productId}`), {
+            headers: this.defaultHeaders,
+        });
+        switch (r.status) {
+            case 422:
+                throw new ValidationError();
+        }
+        return await r.json();
+    }
+
     async purchaseProduct(playerId, productId) {
         const url = this.formatUrl(`/player/${playerId}/product/purchase`);
         const postData = {
@@ -145,6 +174,8 @@ class FairHopper {
                 throw new PlayerNotFoundError();
             case 409:
                 throw new PositionError();
+            case 422:
+                throw new ValidationError();
         }
         return await r.json();
     }

python/fh_sdk.py

@@ -21,6 +21,10 @@ class PlayerNotFoundError(BaseError):
     ...
 
 
+class ValidationError(BaseError):
+    ...
+
+
 class Direction(str, Enum):
     LEFT = "left"
     RIGHT = "right"
@@ -105,7 +109,12 @@ class FairHopper:
             "player_name": player_name,
         }
         r = requests.post(self.format_url("/game"), json=payload)
+
+        if r.status_code == 422:
+            raise ValidationError()
+        else:
             r.raise_for_status()
+
         return StartGameResponse(**r.json())
 
     def get_game_info(self) -> GameInfoResponse:
@@ -113,13 +122,15 @@ class FairHopper:
         r.raise_for_status()
         return GameInfoResponse(**r.json())
 
-    def get_player_info(self, id: str) -> PlayerInfoResponse:
+    def get_player_info(self, player_id: str) -> PlayerInfoResponse:
-        r = requests.get(self.format_url(f"/player/{id}"))
+        r = requests.get(self.format_url(f"/player/{player_id}"))
 
         if r.status_code == 403:
             raise PlayerInactiveError()
         elif r.status_code == 404:
             raise PlayerNotFoundError()
+        elif r.status_code == 422:
+            raise ValidationError()
         else:
             r.raise_for_status()
 
@@ -147,6 +158,8 @@ class FairHopper:
             raise PlayerNotFoundError()
         elif r.status_code == 409:
             raise PositionError()
+        elif r.status_code == 422:
+            raise ValidationError()
         else:
             r.raise_for_status()
 
@@ -157,11 +170,32 @@ class FairHopper:
         response_data = ProductListResponse(**r.json())
         return response_data.products
 
+    def get_product(self, product_id: str) -> Product:
+        r = requests.get(self.format_url(f"/products/{product_id}"))
+
+        if r.status_code == 422:
+            raise ValidationError()
+        else:
+            r.raise_for_status()
+
+        return Product(**r.json())
+
     def purchase_product(self, player_id: str, product_id: str) -> Product:
         url = self.format_url(f"/player/{player_id}/product/purchase")
         payload = {
             "product_id": product_id,
         }
         r = requests.post(url, json=payload)
+
+        if r.status_code == 403:
+            raise PlayerInactiveError()
+        elif r.status_code == 404:
+            raise PlayerNotFoundError()
+        elif r.status_code == 409:
+            raise PositionError()
+        elif r.status_code == 422:
+            raise ValidationError()
+        else:
             r.raise_for_status()
+
         return Product(**r.json())